Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isdef #199

Merged
merged 4 commits into from
Dec 19, 2023
Merged

Fix isdef #199

merged 4 commits into from
Dec 19, 2023

Conversation

cstjean
Copy link
Collaborator

@cstjean cstjean commented Dec 17, 2023

This feels like the simplest fix, though I wonder why it wasn't defined like that in the first place. Hopefully from now on we can increase test coverage on each release.

Fix #172, close #173.

This feels like the simplest fix, though I wonder why it wasn't defined like that in the first
place. Hopefully from now on we can increase test coverage on each release.
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a266470) 79.62% compared to head (28bf092) 79.66%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   79.62%   79.66%   +0.04%     
==========================================
  Files          10       10              
  Lines         422      423       +1     
==========================================
+ Hits          336      337       +1     
  Misses         86       86              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstjean cstjean merged commit 6b3034a into master Dec 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isdef() seems to return true in any case
2 participants