Remove NNlibCUDA dependency to support Flux 0.14 #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fine. Could CUDA as well be removed? |
|
There are 2 I played around with putting them in an extension but there are design decisions that I am not comfortable making so I figured this would be a good solution for until a proper extension can be made. |
darsnack
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in regards to the question I posted on the slack. I asked if NNlibCUDA was a necessary dependency for Metalhead since there is no direct reference to it in the code and it's preventing Flux 0.14 from being used in the same environment as Metalhead.
I made this a draft because I don't know the full repercussions of this change. I'm seeking feedback from more experienced Metalhead/Flux developers.