Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Documenter 1.0 (and some miscellaneous fixes) #266

Merged
merged 3 commits into from
Dec 26, 2023

Conversation

theabhirath
Copy link
Member

@theabhirath theabhirath commented Dec 26, 2023

Tidied up our Documenter workflow a little and also migrated to Documenter 1.0 (which has some more features and has the added benefit of looking nicer!).

One thing that may have been confusing here is the utilities.jl file. It's been listed as part of the Layers module on the docs but hasn't been in that folder? So that's been fixed. The file is still sourced in Metalhead proper though.

Some other miscellaneous fixes:

  1. Not sure what the proper way is to refer to Flux.Conv with a doc reference, but whatever we were doing before wasn't working. Removed the link for now.
  2. Tidied up some of the docstrings with references to stop throwing warnings.
  3. Added a using Downloads to stop a deprecation warning from popping up every time we test.

This is probably a start for some PRs for the docs, hopefully I can find time and improve them further soon.

@theabhirath theabhirath added the documentation Documentation label Dec 26, 2023
Copy link
Contributor

Once the documentation build has completed, you can preview any updated documentation at this URL: https://fluxml.ai/Metalhead.jl/previews/PR266/

@theabhirath
Copy link
Member Author

theabhirath commented Dec 26, 2023

Buildkite errors seem to be mirroring those discussed in #264? So probably not related

Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those Buildkite errors are unexpected, but I also don't see how any of the changes here could be causing them.

@theabhirath theabhirath merged commit 2ad3337 into master Dec 26, 2023
42 of 43 checks passed
@theabhirath theabhirath deleted the a2/docs-fix branch December 26, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants