Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scatter operations #255

Merged
merged 57 commits into from
Mar 5, 2021
Merged

Add scatter operations #255

merged 57 commits into from
Mar 5, 2021

Commits on Jan 11, 2021

  1. add scatter operations

    @yuehhua
    yuehhua committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    a0a5841 View commit details
    Browse the repository at this point in the history

  2. Generalize scatter with op argument and accept AbstractArray

    @yuehhua
    yuehhua committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    81ff677 View commit details
    Browse the repository at this point in the history

  3. Update src/scatter.jl 

    Co-authored-by: Carlo Lucibello <carlo.lucibello@gmail.com>
    @yuehhua @CarloLucibello
    yuehhua and CarloLucibello committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    b2b1b58 View commit details
    Browse the repository at this point in the history

  4. Update src/scatter.jl 

    Co-authored-by: Carlo Lucibello <carlo.lucibello@gmail.com>
    @yuehhua @CarloLucibello
    yuehhua and CarloLucibello committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    2a9f250 View commit details
    Browse the repository at this point in the history

  5. Update src/utils.jl 

    Co-authored-by: Carlo Lucibello <carlo.lucibello@gmail.com>
    @yuehhua @CarloLucibello
    yuehhua and CarloLucibello committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    73a03f0 View commit details
    Browse the repository at this point in the history

  6. Separate scatter mean doc

    @yuehhua
    yuehhua committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    a9ffc85 View commit details
    Browse the repository at this point in the history

  7. Drop redundant line of code

    @yuehhua
    yuehhua committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    b102691 View commit details
    Browse the repository at this point in the history

  8. Update doc and variable names

    @yuehhua
    yuehhua committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    99a5998 View commit details
    Browse the repository at this point in the history

  9. Fix variable name

    @yuehhua
    yuehhua committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    6478cbc View commit details
    Browse the repository at this point in the history

  10. Update docs

    @yuehhua
    yuehhua committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    aa02132 View commit details
    Browse the repository at this point in the history

  11. Add gather

    @yuehhua
    yuehhua committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    f063cb9 View commit details
    Browse the repository at this point in the history

  12. Add least_dims 

    fix
    @yuehhua
    yuehhua committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    1731b1b View commit details
    Browse the repository at this point in the history

  13. Support index represented in tuple 

    fix

Refactor gather

fix
    @yuehhua
    yuehhua committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    e50b808 View commit details
    Browse the repository at this point in the history

  14. Merge gather! functions

    @yuehhua
    yuehhua committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    436e38f View commit details
    Browse the repository at this point in the history

  15. Fix typo

    @yuehhua
    yuehhua committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    582b141 View commit details
    Browse the repository at this point in the history

  16. Scatter: scalar version

    @yuehhua
    yuehhua committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    3768de1 View commit details
    Browse the repository at this point in the history

  17. Add dims argument 

    Fix
    @yuehhua
    yuehhua committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    09ed77a View commit details
    Browse the repository at this point in the history

  18. Update src/scatter.jl 

    Co-authored-by: Peter <adgjl5645@hotmail.com>
    @yuehhua @chengchingwen
    yuehhua and chengchingwen committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    f5f2c93 View commit details
    Browse the repository at this point in the history

  19. Update src/gather.jl 

    Co-authored-by: Michael Abbott <32575566+mcabbott@users.noreply.github.com>
    @yuehhua @mcabbott
    yuehhua and mcabbott committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    0464869 View commit details
    Browse the repository at this point in the history

  20. Do not need colons

    @yuehhua
    yuehhua committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    57e3dce View commit details
    Browse the repository at this point in the history

  21. Update src/scatter.jl 

    Co-authored-by: Michael Abbott <32575566+mcabbott@users.noreply.github.com>
    @yuehhua @mcabbott
    yuehhua and mcabbott committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    a5a6630 View commit details
    Browse the repository at this point in the history

  22. Support gather for scalar and array version

    @yuehhua
    yuehhua committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    625de76 View commit details
    Browse the repository at this point in the history

  23. Add bound checks for gather

    @yuehhua
    yuehhua committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    12c526c View commit details
    Browse the repository at this point in the history

  24. Temporally drop gather_indices

    @yuehhua
    yuehhua committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    40e993c View commit details
    Browse the repository at this point in the history

  25. Make dims as kwargs

    @yuehhua
    yuehhua committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    09c43b8 View commit details
    Browse the repository at this point in the history

  26. Fix bug

    @yuehhua
    yuehhua committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    7f07448 View commit details
    Browse the repository at this point in the history

  27. Add scatter function

    @yuehhua
    yuehhua committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    2f9d8c2 View commit details
    Browse the repository at this point in the history

  28. Draft for scatter gradient

    @yuehhua
    yuehhua committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    24a19ca View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2021

  1. change zygote-style to chainrules-style and refactor

    @yuehhua
    yuehhua committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    6651a3e View commit details
    Browse the repository at this point in the history

  2. replace nothing with DoesNotExist

    @yuehhua
    yuehhua committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    1356965 View commit details
    Browse the repository at this point in the history

  3. correct with NO_FIELDS

    @yuehhua
    yuehhua committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    1f80035 View commit details
    Browse the repository at this point in the history

  4. fix code to be compatible with v1.3

    @yuehhua
    yuehhua committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    70a6409 View commit details
    Browse the repository at this point in the history

  5. extract ∇scatter_src

    @yuehhua
    yuehhua committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    2bda28c View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2021

  1. extract ∇scatter_dst 

    fix
    @yuehhua
    yuehhua committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    8e3ad4a View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. bug fix

    @yuehhua
    yuehhua committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    882a953 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2021

  1. add test_rrule for testing gradient

    @yuehhua
    yuehhua committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    91d8c30 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. rewrite gather

    @CarloLucibello
    CarloLucibello committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    a577725 View commit details
    Browse the repository at this point in the history

  2. project cleanup

    @CarloLucibello
    CarloLucibello committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    cd7c449 View commit details
    Browse the repository at this point in the history

  3. add tests for scatter! and scatter

    @yuehhua
    yuehhua committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    0453f0c View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. add dimensional check for output arrays

    @yuehhua
    yuehhua committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    28bd91f View commit details
    Browse the repository at this point in the history

  2. move gradient of scatter to another PR

    @yuehhua
    yuehhua committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    f9c5647 View commit details
    Browse the repository at this point in the history

  3. fix conflict

    @yuehhua
    yuehhua committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    cdb55fc View commit details
    Browse the repository at this point in the history

  4. move gather implementation to other PR

    @yuehhua
    yuehhua committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    cebf473 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. remove Compat

    @yuehhua
    yuehhua committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    5dfc49b View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2021

  1. remove dims args

    @yuehhua
    yuehhua committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    3783697 View commit details
    Browse the repository at this point in the history

  2. add @inbounds back

    @yuehhua
    yuehhua committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    4f11c40 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. remove restriction of numerical types

    @yuehhua
    yuehhua committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    010af70 View commit details
    Browse the repository at this point in the history

  2. remove type promotion

    @yuehhua
    yuehhua committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    66ded23 View commit details
    Browse the repository at this point in the history

  3. remove inbounds and simd annotations

    @yuehhua
    yuehhua committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    dcc6710 View commit details
    Browse the repository at this point in the history

  4. update error message

    @yuehhua
    yuehhua committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    8faca3d View commit details
    Browse the repository at this point in the history

  5. remove @BoundsCheck

    @yuehhua
    yuehhua committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    e7913b0 View commit details
    Browse the repository at this point in the history

  6. fix

    @yuehhua
    yuehhua committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    e4f0c17 View commit details
    Browse the repository at this point in the history

  7. replace zeros and ones with more generic way

    @yuehhua
    yuehhua committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    ec402d9 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. remove bound checks

    @yuehhua
    yuehhua committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    c6213c6 View commit details
    Browse the repository at this point in the history

  2. optimize

    @yuehhua
    yuehhua committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    4d5cbe8 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. update docs

    @yuehhua
    yuehhua committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    fc7360d View commit details
    Browse the repository at this point in the history

  2. remove not used utilities

    @yuehhua
    yuehhua committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    6542ea9 View commit details
    Browse the repository at this point in the history