Dilation support for Conv #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! I'm a little unfamiliar with where this all lives; do 1D convolutions live here as well, or is that a separate location? (I ask because I want to do WaveNet-style convolutions, which are 1-d dilated convolutions on audio data) |
|
Yes, 1D convolutions are here. Dilation is available for that as well. |
|
Awesome. I'll let @staticfloat have the final word on this; if he's happy we can merge. |
|
I'm happy with it! Please merge away. :) |
|
Thanks @tejank10! |
ToucheSir
pushed a commit
that referenced
this pull request
Feb 13, 2023
Use new `PoolDims` constructor for NNlib v0.8
ToucheSir
pushed a commit
that referenced
this pull request
Feb 13, 2023
Use new `PoolDims` constructor for NNlib v0.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added dilation support for convolution layers (2d and 3d). @staticfloat