Merge #756

756: Call the correct function for irfft(xs,d,dims) r=CarloLucibello a=wkearn Fixes #755 Co-authored-by: William Kearney <William.Kearney.ctr@nrlssc.navy.mil>
FluxML · Aug 8, 2020 · 956575e · 956575e
2 parents 86d1dd5 + 876de6d
commit 956575e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/src/lib/array.jl b/src/lib/array.jl
@@ -931,16 +931,16 @@ end
 end
 
 @adjoint function irfft(xs, d, dims)
-  return AbstractFFTs.ifft(xs, dims), function(Δ)
+  return AbstractFFTs.irfft(xs, d, dims), function(Δ)
     dims = collect(dims)
     N = prod(collect(size(xs))[dims])
-    return (AbstractFFTs.rfft(Δ, dims)/N, nothing, nothing)
+    return (AbstractFFTs.rfft(real.(Δ), dims)/N, nothing, nothing)
   end
 end
 @adjoint function brfft(xs, d, dims)
-  return AbstractFFTs.ifft(xs, dims), function(Δ)
+  return AbstractFFTs.brfft(xs, d, dims), function(Δ)
     dims = collect(dims)
-    return (AbstractFFTs.rfft(Δ, dims), nothing, nothing)
+    return (AbstractFFTs.rfft(real.(Δ), dims), nothing, nothing)
   end
 end
 

diff --git a/test/gradcheck.jl b/test/gradcheck.jl
@@ -1453,8 +1453,7 @@ end
 
   x = randn(Float64,16,16)
   @test typeof(gradient(x->sum(abs2,ifft(fft(x,1),1)),x)[1]) == Array{Complex{Float64},2}
-  # This errors: something is the wrong size
-  #@test typeof(gradient(x->sum(abs2,irfft(rfft(x,1),16,1)),x)[1]) == Array{Float64,2} 
+  @test typeof(gradient(x->sum(abs2,irfft(rfft(x,1),16,1)),x)[1]) == Array{Float64,2} 
 
   x = randn(Float32,16)
   P = plan_fft(x)
@@ -1463,9 +1462,8 @@ end
   @test typeof(gradient(x->sum(abs2,irfft(rfft(x),16)),x)[1]) == Array{Float32,1}
 
   x = randn(Float32,16,16)
-  @test typeof(gradient(x->sum(abs2,ifft(fft(x,1),1)),x)[1]) == Array{Complex{Float32},2}
-  # This errors: something is the wrong size
-  #@test typeof(gradient(x->sum(abs2,irfft(rfft(x,1),16,1)),x)[1]) == Array{Float32,2}
+  @test typeof(gradient(x->sum(abs2,ifft(fft(x,1),1)),x)[1]) == Array{Complex{Float32},2}  
+  @test typeof(gradient(x->sum(abs2,irfft(rfft(x,1),16,1)),x)[1]) == Array{Float32,2}
 end
 
 @testset "FillArrays" begin