Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict some linear algebra adjoints to matrices #545

Merged
merged 3 commits into from
Mar 17, 2020
Merged

Restrict some linear algebra adjoints to matrices #545

merged 3 commits into from
Mar 17, 2020

Conversation

mohamed82008
Copy link
Contributor

This PR restricts the adjoints that make sense for matrices to matrices. This PR fixes TuringLang/Bijectors.jl#90.

@CarloLucibello
Copy link
Member

inv, det and logdet are also defined for Numbers in julia. Can you make sure we don't loose those adjoints and add a test?

@mohamed82008
Copy link
Contributor Author

Done.

@CarloLucibello
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 17, 2020

Build succeeded

@bors bors bot merged commit f16d856 into FluxML:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zygote currently not working with inversion
2 participants
@mohamed82008 @CarloLucibello