Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix gpu integration tests #569

Merged
merged 2 commits into from
Mar 31, 2020
Merged

fix gpu integration tests #569

merged 2 commits into from
Mar 31, 2020

Conversation

CarloLucibello
Copy link
Member

bu adding a compat entry for CuArrays

@DhairyaLGandhi
Copy link
Member

We already have an entry in the extras for a test dependency, and we need to be compatible with CuArrays 2 right?

@CarloLucibello
Copy link
Member Author

We already have an entry in the extras for a test dependency, and we need to be compatible with CuArrays 2 right?

sorry adding to deps was a mistake, check now. I'm not updating to cuarrays 2 here, just making sure that test pass as they used to do

@CarloLucibello
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 31, 2020

Build succeeded

@bors bors bot merged commit 274af93 into master Mar 31, 2020
@DhairyaLGandhi
Copy link
Member

Even so, this would limit the CuArrays version Flux will be able to use right? An up on the environment should have been fine otherwise.

@CarloLucibello
Copy link
Member Author

I tried add Flux#master and the compat here doesn't block the installation of cuarrays 2.0 required by flux

@CarloLucibello
Copy link
Member Author

@dhairyagandhi96 why you say up the environment? CuArrays is not part of the environment...
You mean we should create a Manifest.toml in test/?

@DhairyaLGandhi
Copy link
Member

I tried add Flux#master and the compat here doesn't block the installation of cuarrays 2.0 required by flux

Does that install release Zygote or master?

@CarloLucibello CarloLucibello deleted the cl/cuda branch April 8, 2020 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CarloLucibello @DhairyaLGandhi