Updated DQN CartPole example to utilise Gym's Space types #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DQN example for the CartPole environment and the environment itself has been updated to stop converting the actions (`Discrete(2)`) to `{-1, 1}`. Please refer to this [PR](FluxML/Gym.jl#29) for more details
kraftpunk97-zz
changed the title
This change fixes an error I got and which seems to be due to the multiplication with 0.1 (Float64) converting the array to Array{Float64}
Do not let Float64 creep into the loss function
|
Bump @tejank10 |
…to kraftpunk97/patch-1
tejank10
approved these changes
Jun 25, 2019
|
Also updated the DQN example to use zygote |
|
@tejank10 feel free to merge if you're happy with it (or lmk if you need commit). |
|
Thanks, @kraftpunk97! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DQN example which uses the CartPole environment has been updated to stop converting the actions (
Discrete(2)) to{-1, 1}. Please refer to this PR for more details.