Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pix2pix, CycleGAN, SRGAN #157

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

shreyas-kowshik
Copy link
Contributor

No description provided.

@shreyas-kowshik
Copy link
Contributor Author

shreyas-kowshik commented Jan 21, 2020 via email

@gorskim
Copy link

gorskim commented Jan 21, 2020

Sorry, accidentally deleted my previous comment. Anyway: do you still plan to do something about it? If yes, I looked into the code of SRGAN and noticed that the padding was wrong - it will produce the output not as expected.

@shreyas-kowshik
Copy link
Contributor Author

I plan to get these models trained soon. Just that I am not able to find enough time to debug them separately.
As for the dimension issues, what specific layer do you think is causing the issue?

@gorskim
Copy link

gorskim commented Jan 21, 2020

I think every _Conv and _ConvBN. The padding is 1, so after initial convolution in generator, the dimensions will be decreased and the final output will be not as big as expected. I compared it to some Python code and "they" usually use padding="same". Unfortunately, I don't think there is such an option in Julia (it needs to be calculated in the runtime, I guess).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants