Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make vision models run on Flux v0.10.0 with GPU #187

Merged
merged 6 commits into from Feb 28, 2020
Merged

Make vision models run on Flux v0.10.0 with GPU #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0a9f696
run mnist on Flux v0.10.0/Zygote
Dec 30, 2019
73fb459
make vision models run on Flux v0.10.0
Jan 3, 2020
1862d17
tigy up mnist-conv
Jan 3, 2020
bed6159
revert vae.jl to master
Jan 3, 2020
a64ca18
remove custom adjoint - zygote can differentiate gpu now
Feb 12, 2020
7ec9937
implement code review feedback
Feb 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
500 changes: 294 additions & 206 deletions Manifest.toml
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions Project.toml
View file
Open in desktop
@@ -1,8 +1,10 @@
[deps]
AbstractTrees = "1520ce14-60c1-5f80-bbc7-55ef81b5835c"
BSON = "fbb218c0-5317-5bc6-957e-2ee96dd4b1f0"
CUDAapi = "3895d2a7-ec45-59b8-82bb-cfc6a382f9b3"
Cascadia = "54eefc05-d75b-58de-a785-1a3403f0919f"
Conda = "8f4d0f93-b110-5947-807f-2305c1781a2d"
CuArrays = "3a865a2d-5b23-5a0f-bc46-62713ec82fae"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to explicitly add this and Zygote in? Flux already vendors them

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed Zygote; see my comment above why we need CuArrays - essentially, to turn off scalar indexing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Flux.CuArrays and Flux.Zygote achieve the same

DataStructures = "864edb3b-99cc-5e75-8d2d-829cb0a9cfe8"
Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f"
Flux = "587475ba-b771-5e3f-ad9e-33799f191a9c"
Expand Down