Simplify LeNet #394
Merged
Simplify LeNet #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcabbott
force-pushed
the
simpler_lenet
branch
from
f37d4f2
to
f419ab4
Compare
3 tasks
Merged
mcabbott
commented
May 6, 2023
ToucheSir
reviewed
May 21, 2023
vision/conv_mnist/conv_mnist.jl
Outdated
|
|
||
| # Check that it now agrees with the earlier, trained, model: | ||
|
|
||
| lenet2(cpu(x1)) ≈ cpu(lenet(x1)) |
There was a problem hiding this comment.
Just repeating the suggestion in #397 (comment) to print some of these out so that users running the script directly aren't completely left without feedback.
There was a problem hiding this comment.
See what you think of 9bf6c63, adds more @show.
It doesn't print many headings etc. when run as a script. Could add more but it's all extra clutter. If you run this as a script, I think you need the source open in another window to learn anything anyway.
ToucheSir
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a lot of junk in these files. Perhaps we should clean them up.
Text can go in README. Code should encourage interactive use, and hence avoid big functions called exactly once. No more parameter structs.
Readable version, since the diff is huge: https://github.com/FluxML/model-zoo/blob/simpler_lenet/vision/conv_mnist/conv_mnist.jl
WIP, would like FluxML/Flux.jl#2186 and JuliaML/MLUtils.jl#144 .Edit: or just FluxML/Flux.jl#2240 now.