Added train-test split. Changed performance metric to RMSE #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeInnes
reviewed
Feb 26, 2019
other/housing/housing.jl
Outdated
|
|
||
| x = rawdata[1:13,:] |> gpu | ||
| y = rawdata[14:14,:] |> gpu | ||
|
|
||
| # Normalise the data | ||
| x = (x .- mean(x, dims = 2)) ./ std(x, dims = 2) | ||
|
|
||
| # The model | ||
| # Split into train and test sets | ||
| split_index = convert(Int,floor(size(x,2)*split_ratio)) |
There was a problem hiding this comment.
I think this can be written as floor(Int, ...)
|
Seems like a good idea to me, thanks. |
|
@MikeInnes updated the file |
|
👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be better to have a train-test split ratio as in the Knet.jl/housing.jl code.
The performance metric is updated to RMSE now that we have a test set of more than one element.