Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve definition of adult doublesex neuron #429

Closed
ah963 opened this issue Nov 6, 2018 · 4 comments
Closed

Improve definition of adult doublesex neuron #429

ah963 opened this issue Nov 6, 2018 · 4 comments
Assignees
Labels
coding issue requires some coding tricky non-standard issue that may require extra thought/research VFB related to the nervous system/requested by VFB

Comments

@ah963
Copy link

ah963 commented Nov 6, 2018

Current definition is:

Any neuron (FBbt:00005106) that is part of some adult (FBbt:00003004).

Change to:

Doublesex expressing neuron of the adult.

@Clare72
Copy link
Contributor

Clare72 commented Nov 6, 2018

This is a problem with the autogenerated definition.

This is the logical definition:
neuron and ('part of' some adult) and (expresses some doublesex)

@dosumis how do we get the expression into the autogenerated definition?

@dosumis
Copy link
Collaborator

dosumis commented Nov 6, 2018

I suspect this is because my Perl OBO parser is rejecting the FlyBase IRIs we use for this. Fixing properly will involve editing Perl (or rewriting the autodef script in a different language - probably Scala if I do it). In the meantime, you can fix this by writing a manual definition for this and similar terms. (The autodef only gets added when the definition in the editor's' file = "." )

@Clare72 Clare72 added the VFB related to the nervous system/requested by VFB label Dec 12, 2018
@Clare72
Copy link
Contributor

Clare72 commented Jan 15, 2019

dsx neuron definition fixed - leaving this open as underlying issue (autogeneration of definitions) not fixed.

@Clare72 Clare72 added the coding issue requires some coding label Jan 16, 2019
@Clare72 Clare72 added the tricky non-standard issue that may require extra thought/research label May 8, 2019
@Clare72
Copy link
Contributor

Clare72 commented Aug 14, 2019

Fixed by Nico's new autodefinition generation script.

@Clare72 Clare72 closed this as completed Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coding issue requires some coding tricky non-standard issue that may require extra thought/research VFB related to the nervous system/requested by VFB
Projects
None yet
Development

No branches or pull requests

3 participants