[V2][Sessions] Simplify the logout

[LoicPoullain]

Problem

Logging users out in Foal is not simple and intuitive. It requires a lot of settings that one might not understand.

Solution

Remove extendLifeTimeOrUpdate and removeSessionCookie.

Examples

Without cookies

Before

import {
  dependency, Context, HttpResponseNoContent, Post,
  Session, TokenRequired
} from '@foal/core';
import { TypeORMStore } from '@foal/typeorm';

export class AuthController {

  @dependency
  store: TypeORMStore;

  @Post('/logout')
  @TokenRequired({
    extendLifeTimeOrUpdate: false,
    store: TypeORMStore,
  })
  async logout(ctx: Context<any, Session>) {
    await this.store.destroy(ctx.session.sessionID);

    return new HttpResponseNoContent();
  }

}

After

import {
  Context, HttpResponseNoContent, Post, TokenOptional
} from '@foal/core';
import { TypeORMStore } from '@foal/typeorm';

export class AuthController {

  @Post('/logout')
  @TokenOptional({
    store: TypeORMStore,
  })
  async logout(ctx: Context) {
    if (ctx.session) {
      await ctx.session.destroy();
    }

    return new HttpResponseNoContent();
  }

}

With cookies

Before

import {
  dependency, Context, HttpResponseNoContent, Post,
  removeSessionCookie, Session, TokenRequired
} from '@foal/core';
import { TypeORMStore } from '@foal/typeorm';

export class AuthController {

  @dependency
  store: TypeORMStore;

  @Post('/logout')
  @TokenRequired({
    cookie: true,
    extendLifeTimeOrUpdate: false,
    store: TypeORMStore,
  })
  async logout(ctx: Context<any, Session>) {
    await this.store.destroy(ctx.session.sessionID);

    const response = new HttpResponseNoContent();
    removeSessionCookie(response);
    return response;
  }

}

After

import {
  Context, HttpResponseNoContent, Post, TokenOptional
} from '@foal/core';
import { TypeORMStore } from '@foal/typeorm';

export class AuthController {

  @Post('/logout')
  @TokenOptional({
    cookie: true,
    store: TypeORMStore,
  })
  async logout(ctx: Context) {
    if (ctx.session) {
      await ctx.session.destroy();
    }

    return new HttpResponseNoContent();
  }

}

Steps

See #659

[LoicPoullain]

Implemented in #659.