Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V2][Sessions] Remove the need for a secret #727

Closed
LoicPoullain opened this issue May 27, 2020 · 1 comment
Closed

[V2][Sessions] Remove the need for a secret #727

LoicPoullain opened this issue May 27, 2020 · 1 comment
Labels
feature request
Projects
Issue tracking

Comments

@LoicPoullain
Copy link
Member

LoicPoullain commented May 27, 2020 •
edited
Loading

Problem

The framework requires the use of a secret which is adding an extra step to use authentication with sessions.

Secrets were firstly introduced based on the middleware express-session. This middleware used to use Math.random to generate session IDs, hence the need of the secret. FoalTS uses the randomBytes function which can be used as CPRNG.

Solution

Remove the need for a secret.
@LoicPoullain LoicPoullain added this to Backlog in Issue tracking via automation May 27, 2020
@LoicPoullain LoicPoullain moved this from Backlog to To Do in Issue tracking May 30, 2020
This was referenced Jun 19, 2020
Merged
Merged
@LoicPoullain LoicPoullain moved this from To Do to Work In Progress in Issue tracking Jul 3, 2020
@LoicPoullain
Copy link
Member Author

Resolved in v2

Issue tracking automation moved this from Work In Progress to Done / Closed This Release Jul 3, 2020
@LoicPoullain LoicPoullain mentioned this issue Aug 20, 2020
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
Issue tracking
  
Done / Closed This Release
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LoicPoullain