Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V2][Sessions] Remove the need for a secret #742

Merged
merged 8 commits into from
Jul 3, 2020
Merged

[V2][Sessions] Remove the need for a secret #742

merged 8 commits into from
Jul 3, 2020

Conversation

LoicPoullain
Copy link
Member

Issue

Resolves #727

Solution and steps

  • Make getToken return the session ID.
  • Delete verifyTokenAndGetId.

Breaking changes

  • Session.verifyTokenAndGetId(token) is removed. Use directly the token as session ID instead.

Changes

  • No need for a session secret anymore. It can be removed.
  • All users will be logged out when migrating to v2.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain mentioned this pull request Jun 19, 2020
Merged
@LoicPoullain LoicPoullain added this to Work In Progress in Issue tracking Jul 3, 2020
@LoicPoullain LoicPoullain merged commit 28d2f1b into v2-0-0 Jul 3, 2020
Issue tracking automation moved this from Work In Progress to Done / Closed This Release Jul 3, 2020
@LoicPoullain LoicPoullain deleted the remove-secret branch July 3, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Breaking change enhancement
Projects
Issue tracking
  
Done / Closed This Release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@LoicPoullain