[CLI] Fix installation with yarn on node 10 #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoicPoullain
moved this from Work In Progress
to Done / Closed This Release
in Issue tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The creation of a new project (i.e.
createapp) on Node 10 with yarn is failing: https://github.com/FoalTS/foal/actions/runs/2107640821.Underlying reason: a sub-dependency of a direct dependency requires at least Node v12.
Issue: v2 of Foal still officially supports Node 10 (which is not maintained anymore), so the unique option here is not to check this value in the package.json (which is not great but ok for the situation).
For future major versions of Foal: the minimum version of NodeJS required should always be recent (at least v14 for Foal v3).
Solution
Do no check the
enginein yarn installation .Similar commit: 91414f1