Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support whitespaces around variable names in .env files #1185

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Nov 8, 2022

Issue

Resolves #1182.

Solution and steps

  • Use str.trim()

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain added this to Work In Progress in Issue tracking via automation Nov 8, 2022
@LoicPoullain LoicPoullain mentioned this pull request Nov 8, 2022
6 tasks
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2022

Codecov Report

Base: 98.86% // Head: 98.86% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (deca268) compared to base (d3fea57).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           v3-1-0    #1185   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files          96       96           
  Lines        1667     1668    +1     
  Branches      388      388           
=======================================
+ Hits         1648     1649    +1     
  Misses         19       19           
Impacted Files Coverage Δ
packages/core/src/core/config/env.ts 97.14% <100.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LoicPoullain LoicPoullain merged commit c46e46a into v3-1-0 Nov 8, 2022
@LoicPoullain LoicPoullain deleted the trim-env-key branch November 8, 2022 06:21
Issue tracking automation moved this from Work In Progress to Done / Closed This Release Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Issue tracking
  
Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

None yet

2 participants