Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ctx.controllerName and ctx.controllerMethodeName #1199

Merged
merged 4 commits into from
Dec 22, 2022

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Dec 22, 2022

Issue

Resolves #1183

Solution and steps

  • Add ctx.controllerName and ctx.controllerMethodeName
  • Same with WebsocketContext
  • Pass controller name and method name when instantiating the context
  • Same with WebsocketContext

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain added this to Work In Progress in Issue tracking via automation Dec 22, 2022
@LoicPoullain LoicPoullain mentioned this pull request Dec 22, 2022
2 tasks
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022

Codecov Report

Base: 98.86% // Head: 98.86% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (f5f4f6c) compared to base (dc0875b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##            3-2-0    #1199   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files          96       96           
  Lines        1669     1671    +2     
  Branches      388      389    +1     
=======================================
+ Hits         1650     1652    +2     
  Misses         19       19           
Impacted Files Coverage Δ
packages/core/src/core/http/context.ts 100.00% <100.00%> (ø)
packages/core/src/express/create-app.ts 98.14% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LoicPoullain LoicPoullain merged commit 0bae68f into 3-2-0 Dec 22, 2022
Issue tracking automation moved this from Work In Progress to Done / Closed This Release Dec 22, 2022
@LoicPoullain LoicPoullain deleted the controller-ctx branch December 22, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Issue tracking
  
Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

None yet

2 participants