Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@foal/cli] Refactor createapp command to generate files closest to an SPA. #315

Merged
merged 7 commits into from
Jan 22, 2019

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Jan 21, 2019

Issue

See #231. Related to #279.

Solution and steps

  • Disable CSRF by default.
  • Remove the ViewController.
  • Add an ApiController.
  • Remove the app.*.json files to simplify the get started.
  • Update the tutorials.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain added this to January 2019 in Issue tracking via automation Jan 21, 2019
@LoicPoullain LoicPoullain changed the base branch from master to v0-7-3 January 21, 2019 14:01
@codecov
Copy link

codecov bot commented Jan 21, 2019

Codecov Report

Merging #315 into v0-7-3 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           v0-7-3     #315   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files          45       45           
  Lines         751      751           
  Branches      149      149           
=======================================
  Hits          749      749           
  Misses          2        2
Impacted Files Coverage Δ
packages/core/src/express/create-app.ts 98.27% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23af665...51ff1d7. Read the comment docs.

@LoicPoullain LoicPoullain mentioned this pull request Jan 22, 2019
5 tasks
@LoicPoullain LoicPoullain merged commit d318aee into v0-7-3 Jan 22, 2019
Issue tracking automation moved this from January 2019 to Done Jan 22, 2019
@LoicPoullain LoicPoullain deleted the ssr-to-api branch January 22, 2019 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Issue tracking
  
Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

None yet

1 participant