Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate cookie #398

Merged
merged 2 commits into from Mar 22, 2019
Merged

Validate cookie #398

merged 2 commits into from Mar 22, 2019

Conversation

cr4ftx
Copy link
Contributor

@cr4ftx cr4ftx commented Mar 22, 2019

Issue

See #375

Solution and steps

Just add a ValidateCookies hook like ValidateBody.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #398 into 0-8-7 will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            0-8-7     #398      +/-   ##
==========================================
+ Coverage   98.83%   98.84%   +0.01%     
==========================================
  Files          41       42       +1     
  Lines         686      694       +8     
  Branches      131      132       +1     
==========================================
+ Hits          678      686       +8     
  Misses          8        8
Impacted Files Coverage Δ
...ges/core/src/common/hooks/validate-cookies.hook.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f393e7b...430cc0c. Read the comment docs.

@LoicPoullain LoicPoullain added this to March 2019 in Issue tracking via automation Mar 22, 2019
@LoicPoullain LoicPoullain self-requested a review March 22, 2019 17:26
Copy link
Member

@LoicPoullain LoicPoullain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@LoicPoullain LoicPoullain merged commit aed8e6e into FoalTS:0-8-7 Mar 22, 2019
Issue tracking automation moved this from March 2019 to Done this month Mar 22, 2019
@LoicPoullain LoicPoullain mentioned this pull request Mar 22, 2019
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Issue tracking
  
Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

None yet

2 participants