Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve createapp CLI by adding options #554

Merged
merged 12 commits into from
Oct 28, 2019
Merged

Improve createapp CLI by adding options #554

merged 12 commits into from
Oct 28, 2019

Conversation

fer22f
Copy link
Contributor

@fer22f fer22f commented Oct 20, 2019

Issue

  • No way to stop createapp from automagically choosing between npm and yarn, and the installing process is quite slow (and may be skipped).
  • No way to stop createapp from creating a git repository automagically (other than uninstalling git). Altough git is desirable, you can use others (Mercurial, subversion, who knows).
  • No way to stop createapp from overwriting existing directories.
  • CLI also has a bug where if you specify options before unnamed options (such as ), it shows unneeded usage information, while the command is running.

Solution and steps

  • Add options for these, and for overwriting existing directories, abort the operation if the directory exists.
  • Fix CLI bug.

Checklist

  • Add/update/check tests.

(currently not automatically tested, but has been manually tested, we can discuss this and work on more CLI improvements over time).

@LoicPoullain LoicPoullain added this to Work In Progress in Issue tracking via automation Oct 25, 2019
Copy link
Member

@LoicPoullain LoicPoullain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this PR and for providing this clear description. Some things to improve and we're good 👍

packages/cli/src/index.ts Outdated Show resolved Hide resolved
packages/cli/src/index.ts Outdated Show resolved Hide resolved
packages/cli/src/generate/generators/app/create-app.ts Outdated Show resolved Hide resolved
@LoicPoullain LoicPoullain changed the base branch from master to v1-3-0 October 28, 2019 09:12
@LoicPoullain LoicPoullain merged commit 2d996b1 into FoalTS:v1-3-0 Oct 28, 2019
Issue tracking automation moved this from Work In Progress to Done / Closed This Release Oct 28, 2019
@LoicPoullain LoicPoullain mentioned this pull request Oct 28, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Issue tracking
  
Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

None yet

2 participants