Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to TypeScript version 3, fix MariaDB tests & use Github Actions #557

Merged
merged 13 commits into from
Oct 25, 2019

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Oct 25, 2019

Issue

  • The new version of class-validator, version 0.10.2, only supports TS@v3 (type unknown required). This makes the build of @foal/typestack fail with TS@v2.
  • MariaDB unit tests actually test MySQL database since the default port 3306 is used.
  • For some reason, the Travis pipeline is not triggered anymore when pushing a commit to a PR. It seems that FoalTS project is not detected anymore on Travis website.

Solution and steps

Starting from v1.3.0, FoalTS will only support TS@3.5 and beyond. This should not break current applications because most of them use TS@3.5 and beyond and the others that use TS@2.9 will only need to run npm run typescript@3 to go to the new version without breaking changes (TS@3 is highly compatible with TS@2.9).

  • Build the packages with TypeScript 3.
  • Make MariaDB tests use the right database.
  • Set up a new CI pipeline with Github Actions (beta).

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain added this to Work In Progress in Issue tracking via automation Oct 25, 2019
@codecov
Copy link

codecov bot commented Oct 25, 2019

Codecov Report

❗ No coverage uploaded for pull request base (v1-3-0@c072945). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             v1-3-0     #557   +/-   ##
=========================================
  Coverage          ?   99.57%           
=========================================
  Files             ?       88           
  Lines             ?     1636           
  Branches          ?      371           
=========================================
  Hits              ?     1629           
  Misses            ?        7           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c072945...f91b16e. Read the comment docs.

@LoicPoullain LoicPoullain changed the title Migrate to TypeScript version 3. Migrate to TypeScript version 3 & Use Github Actions Oct 25, 2019
@LoicPoullain LoicPoullain changed the title Migrate to TypeScript version 3 & Use Github Actions Migrate to TypeScript version 3, fix MariaDB tests & use Github Actions Oct 25, 2019
@LoicPoullain LoicPoullain merged commit d5ab94d into v1-3-0 Oct 25, 2019
Issue tracking automation moved this from Work In Progress to Done / Closed This Release Oct 25, 2019
@LoicPoullain LoicPoullain deleted the ts-version3 branch October 25, 2019 20:25
@LoicPoullain LoicPoullain mentioned this pull request Oct 25, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Issue tracking
  
Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

None yet

1 participant