Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Social Auth] Add Google & Facebook providers #563

Merged
merged 37 commits into from
Dec 3, 2019

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Oct 28, 2019

Issue

See #125

Solution and steps

  • Set up the test environment.
    • Create a Google account.
    • Register a test application with the Google account and save the credentials in Github secrets.
    • Create a Facebook account.
    • Register a test application with the Facebook account and save the credentials in Github secrets
  • Create simple applications (samples) using social auth.
    • Google 1
    • Google 2
    • Facebook
  • Add @foal/social package.
    • Create the package.
    • Define the interface and algorithm of AbstractProvider.
    • Add the concrete providers (props only).
    • Implement and test AbstractProvider.
    • Implement and test the providers.
  • Write the documentation.
    • Write Google 1 documentation.
    • Write Google 2 documentation.
    • Write Facebook documentation.
    • How to implement your own provider (mention that settings.social is reserved).

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

External links

https://oauth.net/2/
https://github.com/laravel/socialite
https://developers.google.com/identity/protocols/OpenIDConnect
https://developers.facebook.com/docs/facebook-login/manually-build-a-login-flow/
https://developers.facebook.com/docs/facebook-login/permissions/
https://developers.facebook.com/docs/graph-api/reference/user/

@LoicPoullain LoicPoullain added this to Work In Progress in Issue tracking via automation Oct 28, 2019
@codecov
Copy link

codecov bot commented Oct 28, 2019

Codecov Report

Merging #563 into v1-3-0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           v1-3-0     #563   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files          88       88           
  Lines        1635     1635           
  Branches      372      373    +1     
=======================================
  Hits         1628     1628           
  Misses          7        7
Impacted Files Coverage Δ
packages/core/src/sessions/token.hook.ts 100% <ø> (ø) ⬆️
packages/core/src/sessions/token-required.hook.ts 100% <ø> (ø) ⬆️
packages/core/src/sessions/token-optional.hook.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d48be6...6027ef7. Read the comment docs.

@LoicPoullain LoicPoullain self-assigned this Nov 4, 2019
@LoicPoullain LoicPoullain changed the title [Social Auth] Google, Facebook, Auth0, Cognito, Firebase for SPA+API, Mobile+API, Devices+API [Social Auth] Add Google & Facebook providers Nov 5, 2019
@LoicPoullain LoicPoullain mentioned this pull request Nov 25, 2019
9 tasks
@LoicPoullain LoicPoullain merged commit 70cc46b into v1-3-0 Dec 3, 2019
Issue tracking automation moved this from Work In Progress to Done / Closed This Release Dec 3, 2019
@LoicPoullain LoicPoullain deleted the social-auth-google-fb-spa branch December 3, 2019 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Issue tracking
  
Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

None yet

1 participant