Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dependency version policy more strict. #578

Merged
merged 7 commits into from
Nov 27, 2019

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Nov 27, 2019

Issue

  1. We had issues in the past with dependencies which broke the application on a minor release (which in theory should not happen).

  2. Since v4.17.0, Express exposes the method text of the body-parser. We do not need to have it in the dependencies anymore.

Solution and steps

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

Dependencies

  • @foal/cli
    • ajv@6.10
    • colors@1.4
  • @foal/core
    • @types/express@4.17
    • ajv@6.10
    • express@4.17
  • @foal/ejs
    • ejs@2.7
  • @foal/jwks-rsa
    • jwks-rsa@1.6
  • @foal/jwt
    • jsonwebtoken@8.5
  • @foal/mongodb
    • mongodb@3.3
  • @foal/mongoose
    • @types/mongoose@5.5
  • @foal/swagger
    • swagger-ui-dist@3.24

@LoicPoullain LoicPoullain added this to Work In Progress in Issue tracking via automation Nov 27, 2019
@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #578 into v1-3-0 will decrease coverage by 0.32%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v1-3-0     #578      +/-   ##
==========================================
- Coverage   99.49%   99.17%   -0.33%     
==========================================
  Files          88       65      -23     
  Lines        1588     1087     -501     
  Branches      341      266      -75     
==========================================
- Hits         1580     1078     -502     
- Misses          8        9       +1
Impacted Files Coverage Δ
packages/core/src/express/create-app.ts 95.83% <100%> (-1.67%) ⬇️
packages/core/src/common/hooks/log.hook.ts 66.66% <0%> (-33.34%) ⬇️
packages/core/src/express/handle-errors.ts 75% <0%> (-25%) ⬇️
.../src/openapi/metadata-getters/get-api-used-tags.ts 100% <0%> (ø) ⬆️
...ages/core/src/common/tokens/generate-token.util.ts 100% <0%> (ø) ⬆️
packages/core/src/openapi/utils/merge-tags.ts 100% <0%> (ø) ⬆️
packages/core/src/sessions/token-required.hook.ts 100% <0%> (ø) ⬆️
packages/core/src/common/utils/escape.ts 100% <0%> (ø) ⬆️
...ackages/core/src/sessions/remove-session-cookie.ts 100% <0%> (ø) ⬆️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a4fa84...225dbe5. Read the comment docs.

@LoicPoullain LoicPoullain mentioned this pull request Nov 27, 2019
9 tasks
@LoicPoullain LoicPoullain merged commit 922795a into v1-3-0 Nov 27, 2019
Issue tracking automation moved this from Work In Progress to Done / Closed This Release Nov 27, 2019
@LoicPoullain LoicPoullain deleted the enforce-dependencies branch November 27, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Issue tracking
  
Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

None yet

1 participant