Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use noImplicitAny: any in FoalTS packages #600

Merged
merged 25 commits into from
Dec 17, 2019
Merged

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Dec 17, 2019

Issue

FoalTS framework does not enable the noImplicitAny compilation setting by default. This can cause us to inadvertently miss bugs.

Solution and steps

Use the noImplicitAny option in every package.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain added this to Work In Progress in Issue tracking via automation Dec 17, 2019
@LoicPoullain LoicPoullain changed the title No implicit any Use noImplicitAny: any in FoalTS packages Dec 17, 2019
@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #600 into v1-4-0 will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v1-4-0     #600      +/-   ##
==========================================
- Coverage   99.63%   99.62%   -0.01%     
==========================================
  Files          90       90              
  Lines        1632     1589      -43     
  Branches      363      335      -28     
==========================================
- Hits         1626     1583      -43     
  Misses          6        6
Impacted Files Coverage Δ
...core/src/common/hooks/validate-query-param.hook.ts 100% <100%> (ø) ⬆️
packages/core/src/core/http/contexts.ts 100% <100%> (ø) ⬆️
packages/core/src/common/utils/escape-prop.ts 100% <100%> (ø) ⬆️
packages/core/src/express/not-found.ts 100% <100%> (ø) ⬆️
packages/core/src/core/config.ts 93.4% <100%> (ø) ⬆️
packages/core/src/express/index.ts 100% <100%> (ø) ⬆️
packages/core/src/sessions/session.ts 100% <100%> (ø) ⬆️
packages/core/src/common/utils/escape.ts 100% <100%> (ø) ⬆️
...ages/core/src/common/hooks/validate-header.hook.ts 100% <100%> (ø) ⬆️
.../core/src/common/hooks/validate-path-param.hook.ts 100% <100%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcc2138...da47d4b. Read the comment docs.

@LoicPoullain LoicPoullain merged commit 26fc19a into v1-4-0 Dec 17, 2019
Issue tracking automation moved this from Work In Progress to Done / Closed This Release Dec 17, 2019
@LoicPoullain LoicPoullain deleted the no-implicit-any branch December 17, 2019 15:05
@LoicPoullain LoicPoullain mentioned this pull request Dec 17, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Issue tracking
  
Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

None yet

1 participant