Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@foal/cli] Fix --register failure when no imports #619

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

LoicPoullain
Copy link
Member

Issue

Resolves #606: when the file app.controller.ts does have any imports, the command foal generate controller --register fails.

Solution and steps

  • Fix the bug
  • Improve code

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain added this to Work In Progress in Issue tracking via automation Jan 22, 2020
@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #619 into v1-6-0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           v1-6-0     #619   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files          90       90           
  Lines        1632     1632           
  Branches      363      364    +1     
=======================================
  Hits         1626     1626           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b67fef...034be33. Read the comment docs.

@LoicPoullain LoicPoullain merged commit bff7f96 into v1-6-0 Jan 22, 2020
Issue tracking automation moved this from Work In Progress to Done / Closed This Release Jan 22, 2020
@LoicPoullain LoicPoullain deleted the fix-register-bug branch January 22, 2020 11:10
@LoicPoullain LoicPoullain mentioned this pull request Jan 22, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Issue tracking
  
Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

None yet

1 participant