Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean the build directory before building the app #621

Merged
merged 7 commits into from
Jan 23, 2020
Merged

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Jan 22, 2020

Issue

Resolves #607 (2).

When building the app, the tests, the migrations and the scripts, the build/ folder is not clean up before compiling the files. This may result in keeping in this directory JS files whose TS files have been deleted, causing unexpected behaviors (migrations, spec files, etc).

Solution and steps

  • Add and test the util function rmdir.
  • Add the command foal rmdir.
  • Use foal rmdir build in new projects.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain added this to Work In Progress in Issue tracking via automation Jan 22, 2020
@LoicPoullain LoicPoullain changed the title Foal rmdir Clean the build directory before building the app Jan 22, 2020
@LoicPoullain LoicPoullain mentioned this pull request Jan 22, 2020
6 tasks
@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #621 into v1-6-0 will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           v1-6-0     #621      +/-   ##
==========================================
+ Coverage   99.62%   99.63%   +<.01%     
==========================================
  Files          90       90              
  Lines        1589     1632      +43     
  Branches      335      364      +29     
==========================================
+ Hits         1583     1626      +43     
  Misses          6        6
Impacted Files Coverage Δ
packages/core/src/common/utils/controller.util.ts 100% <0%> (ø) ⬆️
...ages/core/src/common/utils/verify-password.util.ts 100% <0%> (ø) ⬆️
packages/core/src/sessions/token-optional.hook.ts 100% <0%> (ø) ⬆️
packages/core/src/sessions/token-required.hook.ts 100% <0%> (ø) ⬆️
packages/core/src/sessions/set-session-cookie.ts 100% <0%> (ø) ⬆️
...api/metadata-getters/get-api-complete-operation.ts 100% <0%> (ø) ⬆️
packages/core/src/express/create-app.ts 100% <0%> (ø) ⬆️
packages/core/src/express/send-response.ts 100% <0%> (ø) ⬆️
...ackages/core/src/sessions/remove-session-cookie.ts 100% <0%> (ø) ⬆️
packages/core/src/core/routes/utils.ts 100% <0%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bff7f96...2361252. Read the comment docs.

@LoicPoullain LoicPoullain merged commit cb392e5 into v1-6-0 Jan 23, 2020
Issue tracking automation moved this from Work In Progress to Done / Closed This Release Jan 23, 2020
@LoicPoullain LoicPoullain deleted the foal-rmdir branch January 23, 2020 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Issue tracking
  
Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

None yet

1 participant