Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Config to support type and value checking. More detailed errors #641

Merged
merged 30 commits into from
Mar 4, 2020

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Feb 16, 2020

Issue

Fixes #496

Solution and steps

  • Add ConfigNotFoundError
  • Add ConfigTypeError
  • Add Config.get2
  • Add Config.getOrThrow
  • Update Foal's components to use the new methods instead of Config.get.
  • Update the template src/index.ts (and others?).
  • Update getAjvInstance tests (check behavior and invalid types).

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain added this to Work In Progress in Issue tracking via automation Feb 16, 2020
@codecov
Copy link

codecov bot commented Feb 16, 2020

Codecov Report

❗ No coverage uploaded for pull request base (v1-7-0@f6378be). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             v1-7-0     #641   +/-   ##
=========================================
  Coverage          ?   99.64%           
=========================================
  Files             ?       94           
  Lines             ?     1687           
  Branches          ?      381           
=========================================
  Hits              ?     1681           
  Misses            ?        6           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6378be...63548bb. Read the comment docs.

This was referenced Feb 28, 2020
@LoicPoullain
Copy link
Member Author

The acceptance tests in Bash are failing but this is normal since the CLI install version 1.6

@LoicPoullain LoicPoullain merged commit f85bb72 into v1-7-0 Mar 4, 2020
Issue tracking automation moved this from Work In Progress to Done / Closed This Release Mar 4, 2020
@LoicPoullain LoicPoullain deleted the config branch March 4, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Issue tracking
  
Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

None yet

1 participant