Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependency injection] Support interface and generic classes injection #675

Merged
merged 4 commits into from
Apr 17, 2020

Conversation

LoicPoullain
Copy link
Member

Issue

Resolves #627
Resolves #598

Solution and steps

  • Refactor ServiceManager
  • Support service IDs
  • Add @Dependency
  • Make ServiceManger.set return "this"
  • Update the documentation and add an acceptance test.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain added this to Work In Progress in Issue tracking via automation Apr 17, 2020
@LoicPoullain LoicPoullain mentioned this pull request Apr 17, 2020
7 tasks
@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #675 into v1-8-0 will decrease coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v1-8-0     #675      +/-   ##
==========================================
- Coverage   99.63%   99.41%   -0.23%     
==========================================
  Files          94       70      -24     
  Lines        1661     1192     -469     
  Branches      369      302      -67     
==========================================
- Hits         1655     1185     -470     
- Misses          6        7       +1     
Impacted Files Coverage Δ
packages/core/src/core/service-manager.ts 100.00% <100.00%> (ø)
packages/core/src/common/hooks/log.hook.ts 66.66% <0.00%> (-33.34%) ⬇️
packages/core/src/core/config/utils.ts 100.00% <0.00%> (ø)
packages/core/src/core/routes/utils.ts 100.00% <0.00%> (ø)
packages/core/src/express/not-found.ts 100.00% <0.00%> (ø)
packages/core/src/express/create-app.ts 100.00% <0.00%> (ø)
packages/core/src/sessions/constants.ts 100.00% <0.00%> (ø)
packages/core/src/express/send-response.ts 100.00% <0.00%> (ø)
packages/core/src/core/http/http-methods.ts 100.00% <0.00%> (ø)
packages/core/src/common/utils/escape-prop.ts 100.00% <0.00%> (ø)
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef6ca16...0f24ad0. Read the comment docs.

@LoicPoullain LoicPoullain merged commit ba3eaef into v1-8-0 Apr 17, 2020
Issue tracking automation moved this from Work In Progress to Done / Closed This Release Apr 17, 2020
@LoicPoullain LoicPoullain deleted the string-di branch April 17, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Issue tracking
  
Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

None yet

1 participant