Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] Drop NodeJS 8 support and test NodeJS 12. #699

Merged
merged 8 commits into from
May 7, 2020
Merged

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented May 6, 2020

Issue

Since the end of 2019, version 8 of Node is no longer maintained. There is no reason to keep maintaining its support in FoalTS version 2. We will able to use all features of Node 10, especially those on promises in the assert module (for unit testing).

Solution and steps

  • Remove Node 8 from CI and test Node 12.
  • Test Node 12 and make changes if necessary.
  • Remove Node 8 from documentation.
  • Add version warning in @foal/core.
  • Update CLI to generate new project with Node 10 types.
  • Test manually the deployment with version 10 on firebase (to check if the doc is correct).

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain changed the title [V2] Drop NodeJS v8 support and test NodeJS v12. [V2] Drop NodeJS 8 support and test NodeJS 12. May 6, 2020
@LoicPoullain LoicPoullain added this to Work In Progress in Issue tracking May 6, 2020
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #699 into v2-0-0 will decrease coverage by 0.05%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v2-0-0     #699      +/-   ##
==========================================
- Coverage   99.65%   99.59%   -0.06%     
==========================================
  Files          94       94              
  Lines        1727     1732       +5     
  Branches      407      407              
==========================================
+ Hits         1721     1725       +4     
- Misses          6        7       +1     
Impacted Files Coverage Δ
packages/core/src/index.ts 90.00% <80.00%> (-10.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3acf167...68d60a1. Read the comment docs.

@LoicPoullain LoicPoullain mentioned this pull request May 7, 2020
@LoicPoullain LoicPoullain merged commit 44e4c33 into v2-0-0 May 7, 2020
Issue tracking automation moved this from Work In Progress to Done / Closed This Release May 7, 2020
@LoicPoullain LoicPoullain deleted the node-v8-10-12 branch May 7, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Issue tracking
  
Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

None yet

1 participant