Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JWTRequired and TokenRequired work with TypeORM and MongoDB #701

Merged
merged 7 commits into from May 8, 2020

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented May 7, 2020

Issue

Resolves #548.

Solution and steps

  • Add fetchMongoDBUser in @foal/typeorm.
  • Add acceptance test.
  • Docs: when using TokenRequired with MongoDB & TypeORM, MongoDBStore must be used (noSQL) instead of TypeORMStore (SQL).

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain added this to Work In Progress in Issue tracking via automation May 7, 2020
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #701 into v1-9-0 will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           v1-9-0     #701      +/-   ##
==========================================
+ Coverage   99.40%   99.64%   +0.24%     
==========================================
  Files          70       94      +24     
  Lines        1172     1681     +509     
  Branches      301      375      +74     
==========================================
+ Hits         1165     1675     +510     
+ Misses          7        6       -1     
Impacted Files Coverage Δ
packages/core/src/core/config/utils.ts 100.00% <0.00%> (ø)
packages/core/src/core/routes/utils.ts 100.00% <0.00%> (ø)
packages/core/src/express/not-found.ts 100.00% <0.00%> (ø)
packages/core/src/express/create-app.ts 100.00% <0.00%> (ø)
packages/core/src/sessions/constants.ts 100.00% <0.00%> (ø)
packages/core/src/express/handle-errors.ts 100.00% <0.00%> (ø)
packages/core/src/express/send-response.ts 100.00% <0.00%> (ø)
packages/core/src/core/http/http-methods.ts 100.00% <0.00%> (ø)
packages/core/src/common/utils/escape-prop.ts 100.00% <0.00%> (ø)
packages/core/src/common/utils/render.util.ts 100.00% <0.00%> (ø)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df5998d...21b3b2b. Read the comment docs.

@LoicPoullain LoicPoullain merged commit 0f5a004 into v1-9-0 May 8, 2020
Issue tracking automation moved this from Work In Progress to Done / Closed This Release May 8, 2020
@LoicPoullain LoicPoullain deleted the fetch-user-mongodb branch May 8, 2020 07:24
@LoicPoullain LoicPoullain mentioned this pull request May 8, 2020
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Issue tracking
  
Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

None yet

1 participant