Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the objects ObjectDoesNotExist, PermissionDenied and the func… #718

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Conversation

kingdun3284
Copy link
Member

Remove the objects ObjectDoesNotExist, PermissionDenied and the functions isObjectDoesNotExist, isPermissionDenied. They're not being used anywhere and they don't event appear in the documentation.

Issue

#658

Solution and steps

Removed

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

…tions isObjectDoesNotExist, isPermissionDenied. They're not being used anywhere and they don't event appear in the documentation.
@LoicPoullain
Copy link
Member

I'm sorry you spent time on this @kingdun3284 . These objects will finally be kept in version 2 so as to add the feature #638 (HTTP & GraphQL) . I hadn't found time to update v2 description, it's done now.

@LoicPoullain
Copy link
Member

Following this comment, this can be re-opened.

@LoicPoullain LoicPoullain mentioned this pull request Aug 27, 2020
@LoicPoullain LoicPoullain merged commit 42ec80b into FoalTS:v2-0-0 Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants