Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] Remove support of Mongoose #741

Merged
merged 18 commits into from
Jun 19, 2020
Merged

[V2] Remove support of Mongoose #741

merged 18 commits into from
Jun 19, 2020

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Jun 19, 2020

Issue

Mongoose brought many problems in the past while maintaining the framework. It takes time to maintain it and it is also not typed and does not seem to be used by FoalTS users: https://www.npmjs.com/package/@foal/mongoose.

FoalTS will no longer provide Mongoose tools starting from v2 (i.e. CLI code generation and the fetchUser function). Users will still be able to use it "by hand" if they wish.

Closes #668.
Closes #559.

Solution and steps

  • Remove @foal/mongoose
  • Remove all other mentions of mongoose
  • Remove the MongoDB tutorial. With the new createapp --mongodb generation, the code is almost the same as in the SQL Simple To-Do List so there is no need anymore to have a separate tutorial for this.

Breaking changes

  • @foal/mongoose package is removed. If needed, users can copy past the 10-line code.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain added this to Work In Progress in Issue tracking Jun 19, 2020
@LoicPoullain LoicPoullain merged commit 41f3568 into v2-0-0 Jun 19, 2020
Issue tracking automation moved this from Work In Progress to Done / Closed This Release Jun 19, 2020
@LoicPoullain LoicPoullain deleted the remove-mongoose branch June 19, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Issue tracking
  
Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

None yet

1 participant