Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V2][Sessions] Do not let TypeORMStore auto-update the database schema. #767

Merged
merged 6 commits into from
Jul 24, 2020
Merged

[V2][Sessions] Do not let TypeORMStore auto-update the database schema. #767

merged 6 commits into from
Jul 24, 2020

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Jul 24, 2020 •
edited
Loading

Issue

Resolves #766

Solution and steps

  • Add and export DatabaseSession.
  • Update TypeORMStore.
  • Update acceptance tests
  • Add tests on the entity.

Breaking changes

  • All users will be logged out when upgrading to v2.
  • The session table must be created with migrations. A migration file can be created from DatabaseSession.

Optional

  • The old foal_session table can be manually removed.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain added this to Work In Progress in Issue tracking via automation Jul 24, 2020
@LoicPoullain LoicPoullain merged commit 052c561 into v2-0-0 Jul 24, 2020
Issue tracking automation moved this from Work In Progress to Done / Closed This Release Jul 24, 2020
@LoicPoullain LoicPoullain deleted the session-migrations branch July 24, 2020 13:29
@LoicPoullain LoicPoullain mentioned this pull request Jul 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Breaking change feature
Projects
Issue tracking
  
Done / Closed This Release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@LoicPoullain