Fix typestack validateBody hook #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoicPoullain
approved these changes
Aug 7, 2020
| @@ -38,5 +39,5 @@ export function ValidateBody( | |||
| } | |||
|
|
|||
| function isArrowFunction(value: any): value is ((controller: any) => Class) { | |||
| return !value.hasOwnProperty('prototype'); | |||
| return !Object.prototype.hasOwnProperty.call(value, 'prototype'); | |||
There was a problem hiding this comment.
Just to be sure that we won't break, if someone gives us object with builtin properties messed up. Maybe it's overkill
Issue tracking
automation
moved this from Work In Progress
to Done / Closed This Release
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #785
Checklist
I'm not sure what the target branch should be