-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V2] Simplify session system, make it more robust and add new features #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 20, 2020
Issue tracking
automation
moved this from Work In Progress
to Done / Closed This Release
Aug 20, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR solves many issues:
Solution and steps
Breaking changes
get
andset
methods, the interface ofSession
has changed.setSessionCookie
takes the session as argument, no longer the token lonely.createSession
andreadSession
instead of the store directly.createSession(..., { csrfToken: true })
option is removed for now. Usesession.set(csrfToken, await generateToken())
instead.TypeORMStore
.TypeORMStore.getSessionsOf
becomesTypeORMStore.getSessionIDsOf
getRedisInstance
andgetMongoInstance
removed from the stores.TODO at the end: check that the collection and tables names for sessions (redis, mongodb, typeorm) are different from the ones in v1.
Checklist