Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V2][Sessions] Remove the need of setSessionCookie in login #801

Merged
merged 3 commits into from
Aug 20, 2020
Merged

[V2][Sessions] Remove the need of setSessionCookie in login #801

merged 3 commits into from
Aug 20, 2020

Conversation

LoicPoullain
Copy link
Member

Issue

Fixes #796.

Solution and steps

  • Use ctx.session in @Token

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain added this to Work In Progress in Issue tracking via automation Aug 20, 2020
@LoicPoullain LoicPoullain changed the title Remove the need of setSessionCookie in login [V2][Sessions] Remove the need of setSessionCookie in login Aug 20, 2020
@LoicPoullain LoicPoullain mentioned this pull request Aug 20, 2020
Merged
@LoicPoullain LoicPoullain merged commit b4acf6b into v2-0-0 Aug 20, 2020
Issue tracking automation moved this from Work In Progress to Done / Closed This Release Aug 20, 2020
@LoicPoullain LoicPoullain deleted the token-set-session-cookie branch August 20, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
Issue tracking
  
Done / Closed This Release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@LoicPoullain