-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup #804
Merged
Merged
Cleanup #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue tracking
automation
moved this from Work In Progress
to Done / Closed This Release
Sep 10, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & steps
ValidationError
and the functionvalidate
which are unused and do not bring value to the framework.createHttpResponseFile
and useDisk.createHttpResponseFile
instead. Once done, remove the packagemime
from@foal/core
dependencies.@foal/formidable
and use the@ValidateMultipartFormDataBody
hook instead.legacy
option of the functionshashPassword
andverifyPassword
. This option was used in very old versions of Foal when no one was using the framework.@foal/ejs
and the possibility to create FoalTS template engines. Only Express templates engines will be allowed (Twig, EJS, pug, etc).pump
in@foal/core
,@foal/storage
and@foal/aws-s3
and use thepipeline
function from the standard library (added in Node 10).foal g sub-app
.createApp
return a promise and removecreateAndInitApp
. The functioncreateAndInitApp
was introduced because we needed to return a promise.createApp
.This PR also resolves #710.
Breaking changes
@foal/ejs
removed. Install and useejs
directly in config:settings.templateEngine: ejs
.@foal/formidable
andcreateHttpResponseFile
. TODO: write a guide to explain how to useDisk
instead.createApp
returns a promise and callsAppController.init
.hashPassword
. If you use it (very unlikely), please open an issue.createApp(expressInstance)
->createApp({ expressInstance })
.foal g sub-app
removed.validate
function removed.ValidationError
,isValidationError
removed. Use AJV directly instead (or validation hooks).createService
andcreateService
do not accept aserviceManager
as second parameter.Disk
instead ofAbstractDisk
Checklist
Dependencies