Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rest-api deprecations #834

Merged
merged 6 commits into from
Dec 1, 2020
Merged

fix rest-api deprecations #834

merged 6 commits into from
Dec 1, 2020

Conversation

JuanVqz
Copy link
Contributor

@JuanVqz JuanVqz commented Nov 30, 2020 •
edited
Loading

Issue

  • change ValidateParams to ValidatePathParam
  • change ValidateQuery to ValidateQueryParam

Solution and steps

I used the rest-api command yesterday and I saw those deprecation warnings.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

paolodina and others added 6 commits November 28, 2020 02:20
@paolodina
Fix minor typo
30940fc
@LoicPoullain
Merge pull request #831 from paolodina/patch-1
d41da95 
Fix minor typo
fix little typo lerna url
22493a1
@LoicPoullain
Merge pull request #832 from JuanVqz/juanvqz/fix-lerna-url
4558332 
fix little typo lerna url
fix rest-api deprecations
57b53ab 
- [x] change ValidateParams to ValidatePathParam
- [x] change ValidateQuery to ValidateQueryParam
add rest-api controller tests
8033bac
@LoicPoullain LoicPoullain added this to Work In Progress in Issue tracking via automation Dec 1, 2020
@LoicPoullain LoicPoullain self-requested a review December 1, 2020 05:36
@LoicPoullain LoicPoullain changed the base branch from master to v1-12-1 December 1, 2020 07:16
LoicPoullain
LoicPoullain approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@LoicPoullain LoicPoullain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thks 👍

@LoicPoullain LoicPoullain merged commit 390b47a into FoalTS:v1-12-1 Dec 1, 2020
Issue tracking automation moved this from Work In Progress to Done / Closed This Release Dec 1, 2020
@LoicPoullain LoicPoullain mentioned this pull request Dec 1, 2020
Merged
1 task
@JuanVqz
Copy link
Contributor Author

JuanVqz commented Dec 1, 2020

you are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoicPoullain LoicPoullain LoicPoullain approved these changes

Assignees

@JuanVqz JuanVqz

Labels
enhancement
Projects
Issue tracking
  
Done / Closed This Release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JuanVqz @LoicPoullain @paolodina