Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Simplify default create-user script #927

Merged
merged 2 commits into from
May 6, 2021
Merged

Conversation

LoicPoullain
Copy link
Member

Issue

The default create-user script generated by createapp has a lot of commented code that can be "intimidating" and is eventually not very useful. This PR removes the commented lines about groups and permissions and moves them to the documentation.

Solution and steps

  • Update the template
  • Update the groups & permissions page.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain added this to Work In Progress in Issue tracking via automation May 6, 2021
@LoicPoullain LoicPoullain mentioned this pull request May 6, 2021
4 tasks
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2021

Codecov Report

Merging #927 (b5a0b68) into v2-4-0 (fe59733) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           v2-4-0     #927   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files          86       86           
  Lines        1694     1694           
  Branches      406      406           
=======================================
  Hits         1676     1676           
  Misses         18       18           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe59733...b5a0b68. Read the comment docs.

@LoicPoullain LoicPoullain merged commit aa76529 into v2-4-0 May 6, 2021
Issue tracking automation moved this from Work In Progress to Done / Closed This Release May 6, 2021
@LoicPoullain LoicPoullain deleted the simplify-create-user branch May 6, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Issue tracking
  
Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

None yet

2 participants