Commands dropped / bridge overloaded (Err=429) / Connexion issues #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edit check for undefined for the "private groups."
Fixed bug that on off status in a group is not accepted.
Merged from Travlbacon (solves TypeError: Cannot read property 'owner' of undefined)
* Debug 429 * Review error message to console * Added debug to connection to bridge errors * Fine-tuned Error=429 & retries (bridge overloaded) * Finalize Error=429 & retries (bridge overloaded) & clean debug content * Grouped light proper correction * Finalize Error=429 & retries timing optimized (bridge overloaded)
This was referenced Oct 30, 2022
|
Thank you so much for doing this! |
|
Thank you for your work! I tested it and it works like charme! @Foddy can you please merge this PR soon? |
mauricedominic
added a commit
to mauricedominic/node-red-contrib-huemagic
that referenced
this pull request
Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context : HUEMagic becomes more often unusable
Based on what I read, it seems HUE has became more and more strict in what it accepts in terms of external API call rates.
Where the bridge easily accepted many calls per second before, it now rejects them more frequently.
Official HUE dev documentation now mentions a maximum of 4 calls per second (but even more strict for calls to groups which are limited to 1 call / second...)
HUEMagic already handled a retry but :
These caused many issues with commands being delayed to completely lost (not executed).
Error requesting info from the bridge. Reconnect in some secs. undefined. This was caused when HUEMagic polled the bridge to ensure connection was still OK at a moment when the bridge was overloaded (err=429)Because of this, most of us were not able to enjoy HUEMagic nodes :-(
What did I change ?
I have now been running this config for a few weeks and I do not have any connection / drops anymore.
Additional info : merge of other
This pull request also merged #390 from @traverseda and #381 from @Travelbacon, which corrected -very successfully- bugs #375, #374, #377 and #378.
Since then other group issues were reported which should also be solved since I think these are actually the same...
(such as #400)
What you need to do / change ?
I strongly recommend to configure your HUEMagic bridge node using a single 'worker'. Setting more than 1 will always -logically- worsen the overload effect on the bridge.
If you want to use it from now (not waiting for Foddy to merge & publish it), this is possible by installing it manually using command
npm install git+https://github.com/fredblo/node-red-contrib-huemagic.git