-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fody and/or Costura forces PDB generation #278
Comments
I am unable to reproduce this. Make sure the setting to disable PDB generation is set for all configurations (Debug, Release, etc). |
Why would I ever disable PDB generation for all configurations? Perhaps you do not understand how configurations work; only one can be active at any given time, and therefore, I would only need to disable it for the active configuration, never all configurations. As to your attempt to reproduce the issue, what exactly have you observed that makes you think this is not reproducible? To be clear, disabling the PDB generation as per the instructions I linked will omit the PDB from the |
Steps I used to try and reproduce.
|
As I suspected, you have only checked the |
At what point did I say I checked the |
Here's the full code I used to try and reproduce this. https://github.com/distantcam/PDBRepro |
You should not be checking anything under |
You edited your post after I had seen it. As explained in this issue - Fody/Costura#162 - linking to the PDB has nothing to do with Costura or Fody and cannot be disabled by the compiler. |
This is patently false. Removing Fody will immediately cease generating, On 19 Nov 2016 02:48, "Cameron MacFarland" notifications@github.com wrote:
|
Now that I know what I'm looking for (the original description was not helpful) I can confirm this is a Fody bug. I can also reproduce the problem with PropertyChanged. Looking at the https://github.com/Fody/Fody/blob/master/FodyIsolated/ModuleWriter.cs it always writes debug symbols regardless of whether the original assembly has them or not. |
Is it something quick and easy to fix or not? |
fody, and many addins, need the pdb to give better quality errors. Is there some reason you dont wnat to produce a pdb? |
@SimonCropp Certainly. It is because the full physical path to the PDB on the build machine is embedded in the executable which is a privacy concern. |
wouldnt this suffice https://github.com/Fody/Costura/#includedebugsymbols ? |
Since it has been over 6 months I no longer recall if I tried that. I believe I did exhaust all the options before giving up but I can't guarantee it. |
ok fody no longer forces pdb generation |
Fody/Costura forces a PDB to be generated and linked into the target executable even when PDB generation has been explicitly disabled in the build options. Fody/Costura must not override my preference to disable PDB generation.
I am unable to determine whether Fody or Costura is the source of this fault as I cannot use one without the other (Fody throws an exception at build time if there are "no configured weavers"). Since Costura is no longer maintained I hope the error is, in fact, with Fody and that it can be addressed.
The text was updated successfully, but these errors were encountered: