Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ukrainian translation #26

Merged
merged 4 commits into from May 28, 2023
Merged

Add Ukrainian translation #26

merged 4 commits into from May 28, 2023

Conversation

Vovkiv
Copy link
Contributor

@Vovkiv Vovkiv commented May 27, 2023

Congrats on adding i18n support!

@Foldex
Copy link
Owner

Foldex commented May 28, 2023

Thanks for the TL!

Unfortunately while most of it does work, it seems like toasts and dialogs are unaffected:

Dialog

image

Toast

image

But looking through the po shows me that they clearly are present:

msgid "New Release Downloaded: "

msgid "This will reset all customizations made to the Steam client."

and code wise they are using gettext:

body=_("This will reset all customizations made to the Steam client."))

t = Adw.Toast(title=_("New Release Downloaded: ") + msg, timeout=2)

Shrug. Gonna guess the issue is probably on my end, as I'm not that familiar with gettext's nuances.

I did just add a Translators Section to the credits though, so if you can sync up your branch and add in your info I'll go ahead and merge.

TRANSLATORS=[

@Vovkiv
Copy link
Contributor Author

Vovkiv commented May 28, 2023

Yeah, i recently was translating another GTK + Adwaita program (https://gitlab.gnome.org/World/Upscaler/-/issues/24) and there was also issues with non-translated bits, despite them being clearly in po file. I think developer there still didn't catch all untranslated parts in code.

@Foldex Foldex merged commit 437f1c9 into Foldex:main May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants