Fix minor bug when orientation changes for mode sectionHorizontalContentVertical

[PanajotisMaroungas]

No description provided.

[hebertialmeida]

Is it to fix #111? I tested but not fixed that.

[PanajotisMaroungas]

No, it fixes problem for the swipe/scroll mode. The Font menu bug is in every scrollDirection.
I tested the latest pods (which doesn’t include the last PR) and it bug existed.
I think it will be fixed with some constraints. Should I check it?

On 12 Aug 2016, at 14:36, Heberti Almeida notifications@github.com wrote:

Is it to fix #111 https://github.com/FolioReader/FolioReaderKit/issues/111? I tested but not fixed that.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #114 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AOcLE94N2LmXKr1lMdzT8dkMNox1VWApks5qfGi_gaJpZM4Ji4M4.

[hebertialmeida]

We have to do a lot of hacks because this new layout direction, because when I created this generic function I did not prevent your new layout.

I think the best and less buggy what is to refactor this func:
https://github.com/FolioReader/FolioReaderKit/blob/master/Source/FolioReaderKit.swift#L210

To support 3 layouts, so we don't need if else for this.

func isDirection<T> (vertical: T, _ horizontal: T, _ horizontalContentVertical: T) -> T {
    switch readerConfig.scrollDirection {
    case .vertical: return vertical
    case .horizontal: return horizontal
    case .sectionHorizontalContentVertical: return horizontalContentVertical
    }
}

Also I think we can rename the enum case sectionHorizontalContentVertical to horizontalWithVerticalContent, what so you think?

[PanajotisMaroungas]

You’re right. I will start with this now!

[hebertialmeida]

Saved many lines of code 💥