Skip to content
This repository has been archived by the owner on Nov 26, 2020. It is now read-only.

Provide a config which disables the readers UIMenuController #154

Merged
merged 8 commits into from
Sep 27, 2016
Merged

Provide a config which disables the readers UIMenuController #154

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
45c44d1
Provide a config which disables the readers `UIMenuController`
Sep 21, 2016
e006aeb
Remove unneeded `readerConfig.useReaderMenuController` check.
Sep 22, 2016
dfe80c5
Remove unneeded `readerConfig.useReaderMenuController` check.
Sep 22, 2016
eed855c
Merge with solved conflicts
Sep 23, 2016
cf36f95
Expose `FolioReaderWebView` class to external code and fix `useReader…
Sep 23, 2016
c5bebd9
Fix `readerConfig.useReaderMenuController` check
Sep 23, 2016
9eb0a31
Use Swift 2.2 Nimble pod
Sep 23, 2016
5708d6e
Merge with solved conflicts
Sep 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions Source/FolioReaderPage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,10 +425,6 @@ public class FolioReaderPage: UICollectionViewCell, UIWebViewDelegate, UIGesture
// MARK: UIMenu visibility

override public func canPerformAction(action: Selector, withSender sender: AnyObject?) -> Bool {
guard readerConfig.useReaderMenuController else {
return false
}

if UIMenuController.sharedMenuController().menuItems?.count == 0 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can I think you should not remove the guard, because it will call the create menu, the idea is just to call super instead inside the guard.

For customization you can override this without problems.

webView.isColors = false
webView.createMenu(options: false)
Expand Down