This repository has been archived by the owner on Nov 26, 2020. It is now read-only.
Fix retain cycles #67
Merged
+12
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling in Instruments revealed a retain cycle problem. After dismissing FolioReaderContainer still keeps living along with several other objects (FolioReaderCenter, FolioReaderAudioPlayer and so on).
My commit only fixes a use case when FolioReaderContainer is modally presented and then immediately dismissed. No other interactions (e.g. chapter navigation, sharing etc.) were performed. So I suggest a better inspection.
I also noticed that in FolioReaderContainer.swift there are three static variables: readerConfig, epubPath and book. These variables also stay alive after dismissing VC. Maybe FolioReader is a better place for them?