This repository has been archived by the owner on Nov 26, 2020. It is now read-only.
Fixed crash in UIWebView extension #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`UIWebView.canPerformAction(_:withSender:)` would crash UIWebViews outside of FolioReader if a user attempts to open the text menu before the FolioReaderConfig had been set on the singleton.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UIWebView.canPerformAction(_:withSender:)would crash UIWebViews outside of FolioReader if a user attempts to open the text menu before the FolioReaderConfig had been set on the singleton.readerConfigshould be changed to an explicit optional to avoid crashes like this in the future.Alternatively, if possible, we should subclass UIWebView and override these methods there, so that extensions like this do not propagate outside of FolioReader.