Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange bug when uploading if an image is already binded to the control #459

Open
iranor1 opened this issue Jan 19, 2018 · 4 comments
Open

Comments

@iranor1
Copy link

iranor1 commented Jan 19, 2018

I found a strange bug which seems to be recent, and I can't explain it. Croppie has been working flawlessly for months and it started doing it maybe weeks ago (can't tell the last time it worked).

If you bind an image to croppie, and then use FileReader to read another one, it seems that the image is being cropped to 1/4 of the top left corner. The base64 image of the reader result is correct, but right after when I load it using croppie result, it's not good anymore.

If I avoir loading the previous image (no bind before the file reader), the image is correct.

Here's a fiddle to test it: https://jsfiddle.net/wcfth1ac/1/

Load an image, it should display fine. Uncomment the line 7, Run the script, and load another image. You should see the bug. I tested it on Chrome 63 and Firefox 57.

I would suspect a browser update, but since it is happening on two different browsers...

Hope you can help !

@thedustinsmith
Copy link
Contributor

I believe this issue is fixed in this branch: https://github.com/Foliotek/Croppie/tree/pre-2.5.2

@jaymanned
Copy link

When will 2.5.2 be released?

@thedustinsmith
Copy link
Contributor

Should be this week sometime. The new version might actually be 2.6.0 due to some breaking changes.

@jaymanned
Copy link

Great. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants